Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resourceadm: fix agressive re-render using studio debounce #13403

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

mgunnerud
Copy link
Contributor

Description

The current implementation of debounce in resource access lists makes it impossible to change paging; paging is always set back to first page when user navigates to another page.

Related Issue(s)

  • this PR

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@mgunnerud mgunnerud added skip-releasenotes Issues that do not make sense to list in our release notes area/resource-adm Issues related to resource administration labels Aug 20, 2024
@github-actions github-actions bot added the solution/studio/designer Issues related to the Altinn Studio Designer solution. label Aug 20, 2024
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.72%. Comparing base (29196be) to head (9cd9765).
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13403   +/-   ##
=======================================
  Coverage   93.71%   93.72%           
=======================================
  Files        1438     1438           
  Lines       19927    19931    +4     
  Branches     2417     2418    +1     
=======================================
+ Hits        18675    18680    +5     
  Misses       1004     1004           
+ Partials      248      247    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mgunnerud mgunnerud marked this pull request as ready for review August 20, 2024 14:07
@mgunnerud mgunnerud requested a review from wrt95 August 20, 2024 14:07
@mgunnerud mgunnerud merged commit f27941e into main Aug 23, 2024
9 checks passed
@mgunnerud mgunnerud deleted the chore/rrr-debouce-fix branch August 23, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/resource-adm Issues related to resource administration skip-releasenotes Issues that do not make sense to list in our release notes solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants