Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: text-key not updated for options when edited from text-editor #13405

Merged
merged 25 commits into from
Sep 24, 2024
Merged

fix: text-key not updated for options when edited from text-editor #13405

merged 25 commits into from
Sep 24, 2024

Conversation

Jondyr
Copy link
Member

@Jondyr Jondyr commented Aug 20, 2024 •
edited
Loading

Description

This PR makes changes to text keys also update references for:

  • Options for form components (checkboxes, dropdown and radiobuttons)
  • Source property on form components (docs)
  • Json code lists in repo options folder

Other changes/specifications

  • Reference keys should not be deleted when text entry is deleted
  • Filtering option lists to just *.json files

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@github-actions github-actions bot added the solution/studio/designer Issues related to the Altinn Studio Designer solution. label Aug 20, 2024
@Jondyr Jondyr linked an issue Aug 20, 2024 that may be closed by this pull request
Text-key not updated for options when edited from text-editor #12974
Closed
@github-actions github-actions bot added the quality/testing Tests that are missing, needs to be created or could be improved. label Aug 21, 2024
@Jondyr Jondyr force-pushed the 12974-text-key-not-updated-for-options-when-edited-from-text-editor branch from 1d9750d to f4c9bf9 Compare August 22, 2024 07:56
@codecov Codecov
Copy link

codecov bot commented Aug 22, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.22%. Comparing base (715c09e) to head (aabb23e).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #13405   +/-   ##
=======================================
  Coverage   95.22%   95.22%           
=======================================
  Files        1498     1498           
  Lines       20473    20473           
  Branches     2475     2475           
=======================================
  Hits        19496    19496           
  Misses        869      869           
  Partials      108      108

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jondyr Jondyr changed the title Make Options update when text keys are changed in components and code… Text-key not updated for options when edited from text-editor Aug 22, 2024
@Jondyr Jondyr force-pushed the 12974-text-key-not-updated-for-options-when-edited-from-text-editor branch from c7676f9 to d0d58cc Compare August 26, 2024 06:51
@Jondyr Jondyr marked this pull request as ready for review August 26, 2024 07:02
mlqn
mlqn previously approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@mlqn mlqn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM I had to dismiss my approval as I just noticed a potential problem

@mlqn mlqn dismissed their stale review September 4, 2024 15:10

I just noticed a problem

@Jondyr Jondyr changed the title Text-key not updated for options when edited from text-editor fix: text-key not updated for options when edited from text-editor Sep 5, 2024
@Jondyr Jondyr requested a review from mlqn September 5, 2024 10:38
@Jondyr Jondyr requested a review from mlqn September 10, 2024 09:44
mlqn
mlqn approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@mlqn mlqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Geat work! 🚀

@Jondyr Jondyr mentioned this pull request Sep 16, 2024
Merged
4 tasks
@Jondyr Jondyr marked this pull request as draft September 24, 2024 07:31
@Jondyr Jondyr marked this pull request as ready for review September 24, 2024 11:48
standeren
standeren approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@standeren standeren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested OK locally!

@Jondyr Jondyr merged commit ae5bf2c into main Sep 24, 2024
16 checks passed
@Jondyr Jondyr deleted the 12974-text-key-not-updated-for-options-when-edited-from-text-editor branch September 24, 2024 12:53
Jondyr added a commit that referenced this pull request Sep 24, 2024
@Jondyr
fix: text-key not updated for options when edited from text-editor (#…
091218c 
…13405)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlqn mlqn mlqn approved these changes

@standeren standeren standeren approved these changes

Assignees
No one assigned
Labels
quality/testing Tests that are missing, needs to be created or could be improved. solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Text-key not updated for options when edited from text-editor
3 participants
@Jondyr @mlqn @standeren