Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 13391 create a studioerror component and use it instead of alerts with severity #13412

Merged
merged 10 commits into from
Sep 4, 2024
Merged

feat: 13391 create a studioerror component and use it instead of alerts with severity #13412

merged 10 commits into from
Sep 4, 2024

Conversation

JamalAlabdullah
Copy link
Contributor

@JamalAlabdullah JamalAlabdullah commented Aug 22, 2024 •
edited
Loading

Description

  • Created a new compnent StudioError
  • Added test for it.
  • Updated StudioPageError component to make it return StudioError
  • Replaced alerts with severity danger with StudioError.

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@JamalAlabdullah JamalAlabdullah linked an issue Aug 22, 2024 that may be closed by this pull request
Create a StudioError component and use it instead of alerts with severity #13391
Closed
@github-actions github-actions bot added area/data-modeling Area: Related to data models - e.g. create, edit, use data models. area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. area/dashboard Area: Related to the dashboard area/app-deploy Area: Related to deploying apps from Altinn Studio to Altinn Apps. solution/studio/designer Issues related to the Altinn Studio Designer solution. labels Aug 22, 2024
@codecov Codecov
Copy link

codecov bot commented Aug 22, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.75%. Comparing base (c03cfbe) to head (97d2b9e).
Report is 8 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #13412   +/-   ##
=======================================
  Coverage   93.74%   93.75%           
=======================================
  Files        1446     1448    +2     
  Lines       20030    20037    +7     
  Branches     2429     2430    +1     
=======================================
+ Hits        18778    18785    +7     
  Misses       1004     1004           
  Partials      248      248

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JamalAlabdullah
Merge remote-tracking branch 'origin/main' into 13391-create-a-studio…
67eda4c 
…error-component-and-use-it-instead-of-alerts-with-severity
framitdavid
framitdavid requested changes Aug 23, 2024
View reviewed changes
Copy link
Collaborator

@framitdavid framitdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done @JamalAlabdullah! Small and dedicated PR which was easy to review. I think this code change is a great way to isolate the usage of alert, love that!

I got some feedback we should consider before merging this PR. 😊

frontend/libs/studio-components/src/components/StudioError/StudioError.tsx Outdated Show resolved Hide resolved
frontend/libs/studio-components/src/components/StudioError/StudioError.tsx Outdated Show resolved Hide resolved
frontend/app-development/features/appPublish/pages/DeployPage.tsx Outdated Show resolved Hide resolved
frontend/app-development/features/appPublish/containers/DeploymentContainer.tsx Outdated Show resolved Hide resolved
...nents/ShareChangesPopover/CommitAndPushContent/FileChangesInfoModal/FileChangesInfoModal.tsx Show resolved Hide resolved
frontend/libs/studio-components/src/components/StudioPageError/StudioPageError.tsx Show resolved Hide resolved
frontend/libs/studio-components/src/components/StudioPageError/StudioPageError.module.css Show resolved Hide resolved
framitdavid
framitdavid approved these changes Aug 23, 2024
View reviewed changes
Copy link
Collaborator

@framitdavid framitdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rock solid! 🪨

@JamalAlabdullah JamalAlabdullah changed the title 13391 create a studioerror component and use it instead of alerts with severity feat: 13391 create a studioerror component and use it instead of alerts with severity Sep 2, 2024
mlqn
mlqn approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@mlqn mlqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested OK 💯

@mlqn mlqn merged commit b798641 into main Sep 4, 2024
17 of 18 checks passed
@mlqn mlqn deleted the 13391-create-a-studioerror-component-and-use-it-instead-of-alerts-with-severity branch September 4, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlqn mlqn mlqn approved these changes

@framitdavid framitdavid framitdavid approved these changes

Assignees
No one assigned
Labels
area/app-deploy Area: Related to deploying apps from Altinn Studio to Altinn Apps. area/dashboard Area: Related to the dashboard area/data-modeling Area: Related to data models - e.g. create, edit, use data models. area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a StudioError component and use it instead of alerts with severity
3 participants
@JamalAlabdullah @mlqn @framitdavid