-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added validation for CreateCustomReceiptForm and test. #13420
added validation for CreateCustomReceiptForm and test. #13420
Conversation
…ion-when-giving-a-custom-receipt-a-name-with-only-one-character
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13420 +/- ##
=======================================
Coverage 93.72% 93.72%
=======================================
Files 1438 1438
Lines 19929 19930 +1
Branches 2417 2418 +1
=======================================
+ Hits 18679 18680 +1
Misses 1002 1002
Partials 248 248 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @JamalAlabdullah 💪
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When testing I see that that validation message is removed when clicking the Opprett
button when allows me to post the request to backend with the single-letter-name anyway.
Maybe we should disable the Opprett
button until there is a valid input?
Skjermopptak.2024-08-30.kl.11.13.37.mov
@standeren have you tested in my branch? I tested it before and tested now it works validation.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested OK in dev
Description
CreateCustomReceiptForm
component to show the error message as long as the user types just one character.Related Issue(s)
Verification
Documentation