-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: root header doesn't display when there are no elements #13439
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13439 +/- ##
==========================================
- Coverage 93.74% 93.74% -0.01%
==========================================
Files 1446 1446
Lines 20030 20028 -2
Branches 2429 2428 -1
==========================================
- Hits 18778 18776 -2
Misses 1004 1004
Partials 248 248 ☔ View full report in Codecov by Sentry. |
frontend/packages/schema-editor/src/components/SchemaEditor/SchemaEditor.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and it works as expected😊
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 😊
Tested OK in dev! 💯 I just noticed that a generic error is displayed when we try to generate the model, but this will be fixed by this issue: #11037 error.mov |
Description
Removed the logic that returned null when
schemaModel.isEmpty()
was true, as it blocked rendering the root header when only the root element was present. This check, along with the associated method and tests, has been removed.Fixed a race condition that occurred after this removal by adding
setQueryData
for user info, ensuring the cache is ready since user info is fetched at a higher level inPageLayout.tsx
.Related Issue(s)
Verification
Documentation