Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add help text to payment task #13446

Merged
merged 4 commits into from
Aug 30, 2024
Merged

Add help text to payment task #13446

merged 4 commits into from
Aug 30, 2024

Conversation

lassopicasso
Copy link
Contributor

@lassopicasso lassopicasso commented Aug 29, 2024

Description

Add help text to payment task that was missing.

@Ildest , maybe you want to take a review of this? 🙂

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@lassopicasso lassopicasso linked an issue Aug 29, 2024 that may be closed by this pull request
@github-actions github-actions bot added the solution/studio/designer Issues related to the Altinn Studio Designer solution. label Aug 29, 2024
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.74%. Comparing base (5feeb33) to head (a16ec16).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13446   +/-   ##
=======================================
  Coverage   93.74%   93.74%           
=======================================
  Files        1446     1446           
  Lines       20029    20029           
  Branches     2428     2428           
=======================================
  Hits        18777    18777           
  Misses       1004     1004           
  Partials      248      248           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Ildest
Copy link
Contributor

Ildest commented Aug 29, 2024 via email

Copy link
Contributor

@Ildest Ildest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed line a little, looks good

frontend/language/src/nb.json Outdated Show resolved Hide resolved
Copy link
Contributor

@Ildest Ildest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

frontend/language/src/nb.json Show resolved Hide resolved
Copy link
Contributor

@standeren standeren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested OK

@lassopicasso lassopicasso merged commit 3d9525d into main Aug 30, 2024
15 checks passed
@lassopicasso lassopicasso deleted the payment-task-help-text branch August 30, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The help text for the payment tasks is missing
3 participants