Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 12234 remove mui typography #13463

Merged
merged 5 commits into from
Sep 6, 2024
Merged

Conversation

wrt95
Copy link
Contributor

@wrt95 wrt95 commented Sep 3, 2024

Description

  • Removing Typography from @mui

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • Not relevant as the code deleted was deprecated, unused components. And the places the code was edited, the Typography was replaced with Paragraph.

@wrt95 wrt95 linked an issue Sep 3, 2024 that may be closed by this pull request
@github-actions github-actions bot added area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution. labels Sep 3, 2024
@wrt95 wrt95 changed the title Feat: 12234 - remove m UI typography feat: 12234 - remove mui typography Sep 3, 2024
@wrt95 wrt95 changed the title feat: 12234 - remove mui typography feat: 12234 remove mui typography Sep 3, 2024
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.95%. Comparing base (1bb09ba) to head (b0b16ba).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...c/components/toolbar/ConditionalRenderingModal.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13463      +/-   ##
==========================================
+ Coverage   93.68%   93.95%   +0.27%     
==========================================
  Files        1455     1451       -4     
  Lines       20168    20066     -102     
  Branches     2442     2430      -12     
==========================================
- Hits        18894    18854      -40     
+ Misses       1023      961      -62     
  Partials      251      251              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@framitdavid framitdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice clean up! :)

Copy link
Contributor

@standeren standeren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧼

@wrt95 wrt95 merged commit 216d0e1 into main Sep 6, 2024
19 of 20 checks passed
@wrt95 wrt95 deleted the feat--12234---Remove-MUI-Typography branch September 6, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove @mui/material Typography
3 participants