-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add StudioFileUploader to studio-components #13491
chore: Add StudioFileUploader to studio-components #13491
Conversation
c676fe5
to
2c198e6
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13491 +/- ##
==========================================
- Coverage 93.99% 93.99% -0.01%
==========================================
Files 1456 1457 +1
Lines 20108 20108
Branches 2438 2438
==========================================
- Hits 18901 18900 -1
- Misses 954 955 +1
Partials 253 253 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
ae0de89
to
fed4bc3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! 👏
Left a few comments below.
frontend/libs/studio-components/src/components/StudioFileUploader/StudioFileUploader.mdx
Outdated
Show resolved
Hide resolved
frontend/libs/studio-components/src/components/StudioFileUploader/StudioFileUploader.tsx
Outdated
Show resolved
Hide resolved
...tend/app-development/features/dataModelling/SchemaEditorWithToolbar/TopToolbar/XSDUpload.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in dev - works as expected!
Description
Create a
StudioFileUploader
component instudio-components
Add usage in XSD-upload.
Additional changes:
description
toNativeSelect
for data type select in process editor #12725...mdx
files in storybook that did not provide any useful information Delete unnecessary MDX files #13300Related Issue(s)
Verification