Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add StudioFileUploader to studio-components #13491

Merged
merged 4 commits into from
Sep 13, 2024

Conversation

standeren
Copy link
Contributor

@standeren standeren commented Sep 5, 2024

Description

Create a StudioFileUploader component in studio-components
Add usage in XSD-upload.

Additional changes:

Related Issue(s)

  • #{issue number}

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

@github-actions github-actions bot added area/data-modeling Area: Related to data models - e.g. create, edit, use data models. solution/studio/designer Issues related to the Altinn Studio Designer solution. labels Sep 5, 2024
@standeren standeren changed the title Add StudioFileUploader to studio-components chore: Add StudioFileUploader to studio-components Sep 5, 2024
@standeren standeren force-pushed the chore/add-file-uploader-to-studio-components branch from c676fe5 to 2c198e6 Compare September 5, 2024 12:07
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 97.61905% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.99%. Comparing base (924cbd0) to head (c43e211).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
...mponents/StudioFileUploader/StudioFileUploader.tsx 96.55% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13491      +/-   ##
==========================================
- Coverage   93.99%   93.99%   -0.01%     
==========================================
  Files        1456     1457       +1     
  Lines       20108    20108              
  Branches     2438     2438              
==========================================
- Hits        18901    18900       -1     
- Misses        954      955       +1     
  Partials      253      253              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@standeren standeren force-pushed the chore/add-file-uploader-to-studio-components branch from ae0de89 to fed4bc3 Compare September 9, 2024 10:11
Copy link
Contributor

@ErlingHauan ErlingHauan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 👏
Left a few comments below.

Copy link
Contributor

@lassopicasso lassopicasso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in dev - works as expected!

@lassopicasso lassopicasso merged commit c6b3414 into main Sep 13, 2024
16 checks passed
@lassopicasso lassopicasso deleted the chore/add-file-uploader-to-studio-components branch September 13, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/data-modeling Area: Related to data models - e.g. create, edit, use data models. solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
3 participants