Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: added missing text #13499

Closed
wants to merge 1 commit into from
Closed

fix: added missing text #13499

wants to merge 1 commit into from

Conversation

mlqn
Copy link
Contributor

@mlqn mlqn commented Sep 6, 2024 •
edited
Loading

Description

Added missing text

BEFORE AFTER

missing-text-before-1

missing-text-after-1

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)

@github-actions github-actions bot added the solution/studio/designer Issues related to the Altinn Studio Designer solution. label Sep 6, 2024
@mlqn mlqn marked this pull request as ready for review September 6, 2024 11:52
@mlqn mlqn added the skip-releasenotes Issues that do not make sense to list in our release notes label Sep 6, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 6, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.68%. Comparing base (1bb09ba) to head (e3ac769).
Report is 10 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #13499   +/-   ##
=======================================
  Coverage   93.68%   93.68%           
=======================================
  Files        1455     1455           
  Lines       20168    20168           
  Branches     2442     2442           
=======================================
  Hits        18894    18894           
  Misses       1023     1023           
  Partials      251      251

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mlqn mlqn changed the title Fix: added missing text Fix: add missing text Sep 6, 2024
@mlqn mlqn changed the title Fix: add missing text fix: added missing text Sep 6, 2024
standeren
standeren approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@standeren standeren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

@ErlingHauan ErlingHauan self-assigned this Sep 10, 2024
ErlingHauan
ErlingHauan requested changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@ErlingHauan ErlingHauan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find! 😄

Allthough it looks like @nkylstad solved this at the same time here.

Should we close this PR?

@ErlingHauan ErlingHauan assigned mlqn and unassigned ErlingHauan Sep 10, 2024
@mlqn mlqn closed this Sep 10, 2024
@mlqn mlqn removed their assignment Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ErlingHauan ErlingHauan ErlingHauan requested changes

@standeren standeren standeren approved these changes

Assignees
No one assigned
Labels
skip-releasenotes Issues that do not make sense to list in our release notes solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
Team Studio
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mlqn @standeren @ErlingHauan