-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add PDF config for layoutset #13512
chore: Add PDF config for layoutset #13512
Conversation
f197a00
to
d57a769
Compare
d57a769
to
6e08bc0
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13512 +/- ##
==========================================
+ Coverage 94.32% 94.35% +0.02%
==========================================
Files 1543 1550 +7
Lines 20984 21113 +129
Branches 2521 2532 +11
==========================================
+ Hits 19794 19921 +127
- Misses 945 946 +1
- Partials 245 246 +1 ☔ View full report in Codecov by Sentry. |
e7d6582
to
6b90fb1
Compare
...nd/packages/ux-editor/src/components/Properties/PageConfigPanel/PdfConfig/PdfConfig.test.tsx
Fixed
Show fixed
Hide fixed
...nd/packages/ux-editor/src/components/Properties/PageConfigPanel/PdfConfig/PdfConfig.test.tsx
Fixed
Show fixed
Hide fixed
...nd/packages/ux-editor/src/components/Properties/PageConfigPanel/PdfConfig/PdfConfig.test.tsx
Fixed
Show fixed
Hide fixed
...nd/packages/ux-editor/src/components/Properties/PageConfigPanel/PdfConfig/PdfConfig.test.tsx
Fixed
Show fixed
Hide fixed
a3a8574
to
7f1b8b1
Compare
dcf9d1c
to
c48b267
Compare
Starting review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thorough work!
It's great that you notice and clean up unneeded code along the way 😄
I only have some nitpicking comments about the language 😊
d3b2804
to
0111106
Compare
Co-authored-by: Erling Hauan <148075168+ErlingHauan@users.noreply.github.com>
Co-authored-by: Erling Hauan <148075168+ErlingHauan@users.noreply.github.com>
…tate with callback from modal when converting existing PDF
0111106
to
846314b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested OK!
Co-authored-by: Erling Hauan <148075168+ErlingHauan@users.noreply.github.com>
Description
Implements support to set an existing layout as dedicated PDF. Setting it to PDF assigns a PDF-icon to the accordion and moves it to the bottom of the pages-panel in order to separate it from the order. Also implements a unset functionality moving the page back to order and removing the icon. If trying to convert a layout to pdf while there exists a pdf already a modal is shown with the options to convert the existing pdf back to a layout page or deleting it.
This PR also improves the way new layouts are named by simply checking that the autogenerated name does not exist in either
order
orpdfLayoutName
.Related Issue(s)
Verification