Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add test utils in studio-components #13535

Merged
merged 2 commits into from
Sep 18, 2024
Merged

test: Add test utils in studio-components #13535

merged 2 commits into from
Sep 18, 2024

Conversation

TomasEng
Copy link
Contributor

@TomasEng TomasEng commented Sep 12, 2024

Description

Added a directory for test utils in the component library. It contains functions that are common in several component tests.

  • testCustomAttributes to test forwarding of "rest" props
  • testRefForwarding to test forwarding of ref objects and functions
  • testRootClassNameAppending to test that the given class is appended to the default class list of the root element

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)

@github-actions github-actions bot added the solution/studio/designer Issues related to the Altinn Studio Designer solution. label Sep 12, 2024
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.16%. Comparing base (b96cae8) to head (0943cb2).
Report is 12 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13535   +/-   ##
=======================================
  Coverage   95.15%   95.16%           
=======================================
  Files        1458     1462    +4     
  Lines       20123    20162   +39     
  Branches     2438     2440    +2     
=======================================
+ Hits        19149    19188   +39     
  Misses        868      868           
  Partials      106      106           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TomasEng TomasEng marked this pull request as ready for review September 12, 2024 13:34
@TomasEng TomasEng mentioned this pull request Sep 17, 2024
3 tasks
Copy link
Collaborator

@framitdavid framitdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rock Solid! 🪨 This would make it a lot easier to test repeatable stuff! 👏

@TomasEng TomasEng merged commit a185468 into main Sep 18, 2024
11 checks passed
@TomasEng TomasEng deleted the test/add-test-utils branch September 18, 2024 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants