Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ansattporten integration #13537

Merged
merged 11 commits into from
Sep 17, 2024
Merged

feat: ansattporten integration #13537

merged 11 commits into from
Sep 17, 2024

Conversation

mirkoSekulic
Copy link
Collaborator

@mirkoSekulic mirkoSekulic commented Sep 12, 2024 •
edited
Loading

Description

Added initial Ansattporten integration for fetching the scopes

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@github-actions github-actions bot added the solution/studio/designer Issues related to the Altinn Studio Designer solution. label Sep 12, 2024
@mirkoSekulic mirkoSekulic marked this pull request as draft September 12, 2024 18:50
@mirkoSekulic mirkoSekulic marked this pull request as ready for review September 16, 2024 13:26
@codecov Codecov
Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.17%. Comparing base (0af6f66) to head (6f645bb).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #13537   +/-   ##
=======================================
  Coverage   95.17%   95.17%           
=======================================
  Files        1462     1462           
  Lines       20149    20149           
  Branches     2439     2439           
=======================================
  Hits        19176    19176           
  Misses        868      868           
  Partials      105      105

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

framitdavid
framitdavid requested changes Sep 16, 2024
View reviewed changes
Copy link
Collaborator

@framitdavid framitdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rock solid work! (like always) 🪨I just had a few comments for consideration.

backend/src/Designer/Controllers/MaskinPortenController.cs Show resolved Hide resolved
backend/src/Designer/Infrastructure/AnsattPorten/AnsattPortenExtensions.cs Outdated Show resolved Hide resolved
backend/src/Designer/Infrastructure/AnsattPorten/AnsattPortenConstants.cs Show resolved Hide resolved
backend/src/Designer/Infrastructure/AnsattPorten/AnsattPortenExtensions.cs Outdated Show resolved Hide resolved
@framitdavid framitdavid self-requested a review September 16, 2024 20:17
@mirkoSekulic
Copy link
Collaborator Author

Tested deploy in dev.

@mirkoSekulic mirkoSekulic enabled auto-merge (squash) September 17, 2024 07:03
@mirkoSekulic mirkoSekulic merged commit b2d8759 into main Sep 17, 2024
10 checks passed
@mirkoSekulic mirkoSekulic deleted the feature/ap-integration branch September 17, 2024 07:08
standeren pushed a commit that referenced this pull request Sep 17, 2024
@mirkoSekulic @standeren
feat: ansattporten integration (#13537)
f69d179
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@standeren standeren standeren approved these changes

@framitdavid framitdavid Awaiting requested review from framitdavid

Assignees

@mirkoSekulic mirkoSekulic

Labels
solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mirkoSekulic @framitdavid @standeren