-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui-editor): poc a modal for adding components to form #13568
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13568 +/- ##
==========================================
- Coverage 95.29% 95.10% -0.19%
==========================================
Files 1653 1659 +6
Lines 22030 22119 +89
Branches 2594 2605 +11
==========================================
+ Hits 20994 21037 +43
- Misses 790 835 +45
- Partials 246 247 +1 ☔ View full report in Codecov by Sentry. |
frontend/packages/ux-editor/src/containers/DesignView/AddItemModal/AddItemModal.tsx
Fixed
Show fixed
Hide fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! I love that you documented this as a POC and noted that further improvements are necessary if we decide to continue after the test. 👏
DRAFT, only for comparing.
Description
POC for removing component column in favor of a button in-context of the form. The button opens a modal, where the service owner can select a component type to add, and edit the ID before adding to the form.
Test coverage is not great, and there may still be some texts and such that are not in the texts file.
I have added a README to the folder containing the POC components pointing out that the folder should either be deleted once the user test is done, or the code should be refactored.
Everything is implemented behind a feature flag, and as such should not affect regular Studio users. Asking for this PR to be approved so we can use if for a live user test next week.
Related Issue(s)
Verification