Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui-editor): poc a modal for adding components to form #13568

Merged
merged 9 commits into from
Oct 25, 2024

Conversation

nkylstad
Copy link
Member

@nkylstad nkylstad commented Sep 17, 2024

DRAFT, only for comparing.

Description

POC for removing component column in favor of a button in-context of the form. The button opens a modal, where the service owner can select a component type to add, and edit the ID before adding to the form.

Test coverage is not great, and there may still be some texts and such that are not in the texts file.
I have added a README to the folder containing the POC components pointing out that the folder should either be deleted once the user test is done, or the code should be refactored.

Everything is implemented behind a feature flag, and as such should not affect regular Studio users. Asking for this PR to be approved so we can use if for a live user test next week.

Related Issue(s)

  • #{issue number}

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)

@github-actions github-actions bot added area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution. labels Sep 17, 2024
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 49.45055% with 46 lines in your changes missing coverage. Please review.

Project coverage is 95.10%. Comparing base (9ec0e3b) to head (39ac252).

Files with missing lines Patch % Lines
...ontainers/DesignView/AddItemModal/AddItemModal.tsx 37.50% 20 Missing ⚠️
...ners/DesignView/AddItemModal/ItemInfo/ItemInfo.tsx 38.88% 11 Missing ⚠️
...nd/packages/ux-editor/src/utils/formLayoutUtils.ts 25.00% 6 Missing ⚠️
...ignView/AddItemModal/ItemCategory/ItemCategory.tsx 54.54% 5 Missing ⚠️
...tainers/DesignView/AddItemModal/AddItemContent.tsx 72.72% 3 Missing ⚠️
...packages/ux-editor/src/containers/FormDesigner.tsx 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13568      +/-   ##
==========================================
- Coverage   95.29%   95.10%   -0.19%     
==========================================
  Files        1653     1659       +6     
  Lines       22030    22119      +89     
  Branches     2594     2605      +11     
==========================================
+ Hits        20994    21037      +43     
- Misses        790      835      +45     
- Partials      246      247       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nkylstad nkylstad marked this pull request as ready for review October 24, 2024 18:35
Copy link
Collaborator

@framitdavid framitdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! I love that you documented this as a POC and noted that further improvements are necessary if we decide to continue after the test. 👏

@framitdavid framitdavid added skip-manual-testing PRs that do not need to be tested manually and removed skip-manual-testing PRs that do not need to be tested manually labels Oct 25, 2024
@framitdavid framitdavid merged commit 0808b19 into main Oct 25, 2024
6 of 8 checks passed
@framitdavid framitdavid deleted the feat(ui-editor)/poc-add-component-modal branch October 25, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. frontend solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants