-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: NaN in new policy rule ID #13598
Conversation
…ix/NaN-for-new-policy-rul
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13598 +/- ##
=======================================
Coverage 95.21% 95.21%
=======================================
Files 1497 1497
Lines 20455 20462 +7
Branches 2473 2474 +1
=======================================
+ Hits 19476 19483 +7
Misses 872 872
Partials 107 107 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solid👍
Accounts for potential reordering of the list in the future👏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested OK in dev ✅
Description
Fixes NaN in rule ID when creating a new policy rule, when the previous rule was a string.
Related Issue(s)
Before
1.mov
After
settings-issue-after.mp4
Verification