Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: NaN in new policy rule ID #13598

Merged
merged 2 commits into from
Sep 25, 2024
Merged

fix: NaN in new policy rule ID #13598

merged 2 commits into from
Sep 25, 2024

Conversation

ErlingHauan
Copy link
Contributor

@ErlingHauan ErlingHauan commented Sep 23, 2024

Description

Fixes NaN in rule ID when creating a new policy rule, when the previous rule was a string.

Related Issue(s)

Before

1.mov

After

settings-issue-after.mp4

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)

@github-actions github-actions bot added the solution/studio/designer Issues related to the Altinn Studio Designer solution. label Sep 23, 2024
@ErlingHauan ErlingHauan added the kind/bug Used when there is a defect / something is not working as it should. label Sep 23, 2024
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.21%. Comparing base (ed8886d) to head (37a105f).
Report is 14 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13598   +/-   ##
=======================================
  Coverage   95.21%   95.21%           
=======================================
  Files        1497     1497           
  Lines       20455    20462    +7     
  Branches     2473     2474    +1     
=======================================
+ Hits        19476    19483    +7     
  Misses        872      872           
  Partials      107      107           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ErlingHauan ErlingHauan marked this pull request as ready for review September 23, 2024 09:48
@Jondyr Jondyr self-assigned this Sep 23, 2024
Copy link
Member

@Jondyr Jondyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid👍
Accounts for potential reordering of the list in the future👏

Copy link
Contributor

@mlqn mlqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested OK in dev ✅

@mlqn mlqn merged commit ac6c082 into main Sep 25, 2024
21 checks passed
@mlqn mlqn deleted the fix/NaN-for-new-policy-rul branch September 25, 2024 07:30
@mlqn mlqn removed their assignment Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend kind/bug Used when there is a defect / something is not working as it should. solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants