fix: Error when deleting local changes.

[Konrad-Simso]

Description

This PR includes the following changes:

• Bugfix
• Refactoring of a query to split into a mutation and a useQuery.
• Moved a common function between 2 files to be in a utils folder.
• Added a test for new utils function and update old tests.

The bugfix was related to the order of when certain components were rerendering. This has been fixed by changing what is invalidated in the cache during deletion and when to load certain components based on query results.

Related Issue(s)

• Error when deleting local changes #13494

Verification

• Your code builds clean without any errors or warnings
• Manual testing done (required)
• Relevant automated test added (if you find this hard, leave it and we'll help out)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.25%. Comparing base (710812b) to head (5aebb81).
Report is 34 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #13669   +/-   ##
=======================================
  Coverage   94.24%   94.25%           
=======================================
  Files        1531     1532    +1     
  Lines       20885    20906   +21     
  Branches     2521     2522    +1     
=======================================
+ Hits        19684    19705   +21     
  Misses        948      948           
  Partials      253      253           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mlqn]

Nice work! 🚀 I just have one suggestion regarding the validation of the selectedOption / modelPath

[Konrad-Simso]

Nice work! 🚀 I just have one suggestion regarding the validation of the selectedOption / modelPath

Your suggestions makes the bug exist again.
Without filtering in both places, SchemaEditorWithToolbar.tsx and TopToolbar.tsx, then some component will rerender with the wrong modelPath selected. I've added the filter to both files and removed the Utils function in the last commit.

Is this an okay solution?

[mlqn]

I don't think we need to duplicate the find in both components. Did you pass the existingSelectedOption to the TopToolbar when you tested?
selectedOption={existingSelectedOption}

[Konrad-Simso]

I don't think we need to duplicate the find in both components. Did you pass the existingSelectedOption to the TopToolbar when you tested? selectedOption={existingSelectedOption}

i'll try it

Edit: It worked, commit on the way

[mlqn]

Nice work! 🚀

[JamalAlabdullah]

Tested ok 👍