Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui-editor): configuration of subform layoutset with allowed components only #13675

Merged
merged 13 commits into from
Oct 8, 2024
Merged

feat(ui-editor): configuration of subform layoutset with allowed components only #13675

merged 13 commits into from
Oct 8, 2024

Conversation

framitdavid
Copy link
Collaborator

@framitdavid framitdavid commented Oct 1, 2024 •
edited
Loading

Description

Please read the linked issue.

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

@framitdavid framitdavid added the skip-releasenotes Issues that do not make sense to list in our release notes label Oct 1, 2024
@github-actions github-actions bot added area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution. labels Oct 1, 2024
@framitdavid framitdavid linked an issue Oct 1, 2024 that may be closed by this pull request
Support configuration of subform layoutset with allowed components only #13475
Closed
@codecov Codecov
Copy link

codecov bot commented Oct 1, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.33%. Comparing base (fe5395f) to head (248bebb).
Report is 21 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #13675   +/-   ##
=======================================
  Coverage   94.32%   94.33%           
=======================================
  Files        1543     1546    +3     
  Lines       20984    21009   +25     
  Branches     2521     2522    +1     
=======================================
+ Hits        19794    19819   +25     
  Misses        945      945           
  Partials      245      245

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@framitdavid framitdavid marked this pull request as draft October 1, 2024 12:41
@framitdavid framitdavid changed the title feat(ui-editor): configuration of subform layoutset with allowed components only wip(ui-editor): configuration of subform layoutset with allowed components only Oct 1, 2024
@framitdavid framitdavid changed the title wip(ui-editor): configuration of subform layoutset with allowed components only feat(ui-editor): configuration of subform layoutset with allowed components only Oct 1, 2024
@framitdavid framitdavid marked this pull request as ready for review October 1, 2024 17:50
Jondyr
Jondyr reviewed Oct 3, 2024
View reviewed changes
Copy link
Member

@Jondyr Jondyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice overall 👍

I have some minor nitpicks for you to consider.

frontend/packages/ux-editor/src/components/Elements/types/ConfigPageType.ts Show resolved Hide resolved
frontend/packages/ux-editor/src/components/Elements/Elements.tsx Outdated Show resolved Hide resolved
frontend/packages/ux-editor/src/components/Elements/ElementsUtils.ts Outdated Show resolved Hide resolved
framitdavid and others added 2 commits October 4, 2024 13:03
@framitdavid @Jondyr
Update frontend/packages/ux-editor/src/components/Elements/Elements.tsx
3c52349 
Co-authored-by: Jonas Dyrlie <jonas.dyrlie@gmail.com>
@framitdavid @Jondyr
Update frontend/packages/ux-editor/src/components/Elements/ElementsUt…
248bebb 
…ils.ts

Co-authored-by: Jonas Dyrlie <jonas.dyrlie@gmail.com>
@wrt95
Copy link
Contributor

wrt95 commented Oct 8, 2024

Tested OK in Dev 🥳

@wrt95 wrt95 merged commit aae8aef into main Oct 8, 2024
17 checks passed
@wrt95 wrt95 deleted the feat/supportedComponentsOnlySubForm branch October 8, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jondyr Jondyr Jondyr approved these changes

@wrt95 wrt95 wrt95 approved these changes

Assignees
No one assigned
Labels
area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. skip-releasenotes Issues that do not make sense to list in our release notes solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support configuration of subform layoutset with allowed components only
3 participants
@framitdavid @wrt95 @Jondyr