Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(resource-adm): use new StudioPageHeader component in resourceadm #13699

Conversation

mgunnerud
Copy link
Contributor

@mgunnerud mgunnerud commented Oct 4, 2024

Description

  • Replace old <AppHeader /> in resource admin with new StudioPageHeader component
  • Create utility function to get name of app from organization (app name in resourceadm is always <org>-resources)

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@mgunnerud mgunnerud linked an issue Oct 4, 2024 that may be closed by this pull request
@github-actions github-actions bot added solution/studio/designer Issues related to the Altinn Studio Designer solution. frontend labels Oct 4, 2024
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.41%. Comparing base (939464c) to head (27d1c0f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13699      +/-   ##
==========================================
- Coverage   94.41%   94.41%   -0.01%     
==========================================
  Files        1574     1576       +2     
  Lines       21276    21316      +40     
  Branches     2541     2546       +5     
==========================================
+ Hits        20088    20125      +37     
  Misses        943      943              
- Partials      245      248       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mgunnerud mgunnerud marked this pull request as ready for review October 4, 2024 13:23
@mgunnerud mgunnerud added area/resource-adm Issues related to resource administration skip-releasenotes Issues that do not make sense to list in our release notes labels Oct 4, 2024
@mgunnerud mgunnerud requested a review from wrt95 October 4, 2024 13:24
Copy link
Contributor

@wrt95 wrt95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@wrt95 wrt95 added the skip-manual-testing PRs that do not need to be tested manually label Oct 4, 2024
@mgunnerud mgunnerud merged commit c3f6f5e into main Oct 4, 2024
17 of 18 checks passed
@mgunnerud mgunnerud deleted the chore/13697-resourceadm-use-new-studiopageheader-component-in-resourceadm branch October 4, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/resource-adm Issues related to resource administration frontend skip-manual-testing PRs that do not need to be tested manually skip-releasenotes Issues that do not make sense to list in our release notes solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resourceadm: use new StudioPageHeader component in resourceadm
2 participants