-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Create basic input table component #13719
Conversation
frontend/libs/studio-components/src/components/StudioInputTable/Cell/CellCheckbox.tsx
Fixed
Show fixed
Hide fixed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13719 +/- ##
==========================================
+ Coverage 94.42% 94.45% +0.02%
==========================================
Files 1582 1598 +16
Lines 21365 21478 +113
Branches 2549 2550 +1
==========================================
+ Hits 20173 20286 +113
Misses 943 943
Partials 249 249 ☔ View full report in Codecov by Sentry. |
f1e3f04
to
9c8f62a
Compare
9c8f62a
to
ccaf622
Compare
…tinn-studio into grunnlag-inndatatabell
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! 😄 I just have 1 question, see commented file
frontend/libs/studio-components/src/components/StudioInputTable/types/CellCoords.ts
Outdated
Show resolved
Hide resolved
I have now removed the unused file. I also made a minor CSS change to centralize the button in the button cell. In addition, I have made some small changes to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
Added the |
Description
Created a new component for tables that contain input fields. The component is built on
StudioTable
, but contains some additional compound components:StudioInputTable.Cell.Textfield
StudioInputTable.Cell.Textarea
StudioInputTable.Cell.Button
StudioInputTable.Cell.Checkbox
StudioInputTable.HeaderCell.Checkbox
These components are meant to be used instead of plain cells where the cells are supposed to contain the given input element. The input components are defined in classes that extend a
BaseInputCell
class. The base class currently only contains arender
method, but it will be extended in future pull requests with keyboard interaction functionality. This pattern will allow us to use the same functions across different components.The following functionality is not included and will be added in follow-up pull requests:
change
handlers on row and table levelVideo
Spiller.inn.2024-10-07.124017.mp4
Related Issue(s)
Verification