Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support configuration for rendering summaries of current and previous tasks #13752

Conversation

mlqn
Copy link
Contributor

@mlqn mlqn commented Oct 9, 2024

Description

  • Added support for rendering summaries of current and previous tasks.
  • Set the fieldset size to small so that all design system components (e.g., NativeSelect, ComboBox) have the same size.

In this first version, all taskIds will be displayed, and it will be the user's responsability to select a previous or current taskId, similar to how we handled uniqueFromSignaturesInDataTypes in the signin tasks.

new-taskid

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@mlqn mlqn linked an issue Oct 9, 2024 that may be closed by this pull request
3 tasks
@github-actions github-actions bot added area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution. frontend labels Oct 9, 2024
@mlqn mlqn changed the title feat: Support configuration for rendering summaries of current and previous… feat: Support configuration for rendering summaries of other tasks Oct 9, 2024
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.55%. Comparing base (a591d37) to head (5161661).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13752   +/-   ##
=======================================
  Coverage   94.54%   94.55%           
=======================================
  Files        1621     1621           
  Lines       21677    21694   +17     
  Branches     2549     2555    +6     
=======================================
+ Hits        20495    20512   +17     
  Misses        939      939           
  Partials      243      243           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mlqn mlqn changed the title feat: Support configuration for rendering summaries of other tasks feat: Support configuration for rendering summaries of current and previous tasks Oct 9, 2024
@mlqn mlqn marked this pull request as ready for review October 9, 2024 13:39
Copy link
Contributor

@JamalAlabdullah JamalAlabdullah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works fine👍

@JamalAlabdullah JamalAlabdullah merged commit 0d2927a into main Oct 11, 2024
17 checks passed
@JamalAlabdullah JamalAlabdullah deleted the 13520-support-configuration-for-rendering-summaries-of-current-and-previous-tasks branch October 11, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. frontend solution/studio/designer Issues related to the Altinn Studio Designer solution. team/studio-domain2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support configuration for rendering summaries of current and previous tasks
3 participants