-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Align the main headings on the data model page #13786
Open
ErlingHauan
wants to merge
11
commits into
main
Choose a base branch
from
fix/css-schema-inspector
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
fc539da
Align datamodel heading and schemaInspector tabs
ErlingHauan 21258a0
Add separate heading and text content when no data model fields are s…
ErlingHauan a4917a2
Align TypesInspector heading with the other headings
ErlingHauan ac7fd59
Create border below headings for types, datamodel and properties
ErlingHauan 98e99b6
Merge branch 'main' into fix/css-schema-inspector
ErlingHauan 54d7553
Clean up
ErlingHauan 1b2dc95
Fix selected type being sunk to bottom
ErlingHauan 8687736
Update headings and add a test for no item selected
ErlingHauan 97f9054
Fix most PR comments
ErlingHauan 6353e90
Add label and vertical divider to toolbar
ErlingHauan e30ff38
Design decided, but not functionally implemented
ErlingHauan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
8 changes: 8 additions & 0 deletions
8
...lopment/features/dataModelling/SchemaEditorWithToolbar/TopToolbar/SchemaSelect.module.css
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,12 @@ | ||
.selectContainer { | ||
display: flex; | ||
align-items: center; | ||
gap: var(--fds-spacing-4); | ||
} | ||
|
||
.select { | ||
display: flex; | ||
flex-direction: row; | ||
cursor: pointer; | ||
min-width: 20vw; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
38 changes: 21 additions & 17 deletions
38
frontend/packages/schema-editor/src/components/NodePanel/HeadingRow/HeadingRow.module.css
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,26 +1,30 @@ | ||
.root { | ||
--gap: var(--fds-spacing-1); | ||
align-items: center; | ||
display: flex; | ||
padding: var(--gap) 0; | ||
gap: var(--gap); | ||
align-items: center; | ||
height: var(--subtoolbar-height); | ||
gap: var(--fds-spacing-3); | ||
border-bottom: 1px solid var(--fds-semantic-border-neutral-subtle); | ||
} | ||
|
||
.heading { | ||
display: contents; | ||
.headingButton { | ||
display: flex; | ||
font: var(--fds-typography-paragraph-short-large); | ||
border-top-left-radius: 0; | ||
border-bottom-left-radius: 0; | ||
border: 0; | ||
} | ||
|
||
.heading .headingButton { | ||
border-bottom-left-radius: 0; | ||
border-left-color: transparent; | ||
border-left-style: solid; | ||
border-left-width: var(--studio-treeitem-vertical-line-width); | ||
border-top-left-radius: 0; | ||
font: var(--fds-typography-paragraph-short-large); | ||
min-height: var(--fds-sizing-12); | ||
.headingButton:hover { | ||
background-color: var(--fds-colors-blue-100); | ||
} | ||
|
||
.root.selected .headingButton { | ||
background-color: var(--studio-treeitem-selected-background-colour); | ||
border-left-color: var(--studio-treeitem-vertical-line-colour-root); | ||
.selected .headingButton { | ||
/*background-color: var(--studio-treeitem-selected-background-colour);*/ | ||
background: linear-gradient( | ||
to right, | ||
var(--studio-treeitem-vertical-line-colour-root) 0 var(--studio-treeitem-vertical-line-width), | ||
var(--studio-treeitem-selected-background-colour) var(--studio-treeitem-vertical-line-width) | ||
100% | ||
); | ||
/*border-left-color: var(--studio-treeitem-vertical-line-colour-root);*/ | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check notice
Code scanning / CodeQL
Unused variable, import, function or class Note