Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Removed single quotation marks on -knapp strings #13791

Merged
merged 3 commits into from
Oct 16, 2024

Conversation

Ildest
Copy link
Contributor

@Ildest Ildest commented Oct 15, 2024

Description

Removed single quotation marks around
-knapp, for example ´Lagre´-knapp.

Checked for similar strings with double quotation marks, but found none.

Commented on strigns not changed - for example expression strings. Please advice.

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@github-actions github-actions bot added solution/studio/designer Issues related to the Altinn Studio Designer solution. frontend labels Oct 15, 2024
@Ildest Ildest marked this pull request as ready for review October 15, 2024 08:52
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.57%. Comparing base (b8d6903) to head (c68da12).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13791   +/-   ##
=======================================
  Coverage   94.57%   94.57%           
=======================================
  Files        1624     1624           
  Lines       21817    21817           
  Branches     2572     2572           
=======================================
  Hits        20634    20634           
  Misses        940      940           
  Partials      243      243           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Ildest Ildest changed the title Removed single quotation marks on -knapp strings Refactor: Removed single quotation marks on -knapp strings Oct 15, 2024
@Ildest Ildest enabled auto-merge (squash) October 15, 2024 09:07
@Ildest Ildest changed the title Refactor: Removed single quotation marks on -knapp strings refactor: Removed single quotation marks on -knapp strings Oct 15, 2024
Copy link
Member

@Jondyr Jondyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@Ildest Ildest merged commit c33e573 into main Oct 16, 2024
9 checks passed
@Ildest Ildest deleted the Content-design-minor-refactor-s51 branch October 16, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minor refactoring: Remove quotation marks around "legg til" in "legg til"-button
3 participants