chore(process): Inform user of consequences of switching layoutset default data model

[nkylstad]

Description

Added an alternative text for combobox description when a data model is already selected. The text explains the consequences of switching to a different data model.

With no previously selected data model (as before):

With previously selected data model (new text):

Also fixed the following that I noticed:

• Bug that did not show the selected value as selected in the combobox. The combobox appeared to have no selected value, even though one was selected.
• Replaced use of Combobox directly from design system with StudioCombobox.

Would like feedback on the text content for the new text, maybe @Ildest could take a look?

"Du har allerede valgt en datamodell. Hvis du har brukt denne datamodellen i skjema kan eventuelle knytninger til datamodellfelt i skjemaet bli ugyldige. Felter det gjelder vil vises med feilmelding i forhåndsvisningen"

Related Issue(s)

• Inform user of consequences of switching datamodel in layoutset #13793

Verification

• Your code builds clean without any errors or warnings
• Manual testing done (required)
• Relevant automated test added (if you find this hard, leave it and we'll help out)

[Ildest]

Maybe tweak the message a bit @nkylstad: "Du har allerede valgt en datamodell. Hvis du har brukt denne datamodellen i et skjema, kan du få ugyldige knytninger til datamodellfelt i skjemaet. Du får en feilmelding om hvilke felter det gjelder, i forhåndsvisningen"

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.57%. Comparing base (36f0b3e) to head (0c4850c).
Report is 72 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #13794   +/-   ##
=======================================
  Coverage   94.57%   94.57%           
=======================================
  Files        1623     1623           
  Lines       21798    21798           
  Branches     2570     2571    +1     
=======================================
  Hits        20616    20616           
  Misses        939      939           
  Partials      243      243           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[standeren]

Nice! 🎯
Left a small comment that has nothing to do with the functionality so feel free to fix or ignore 😎

[Konrad-Simso]

Nice! It works as expected 😄 I've added a suggestion, but it's up to you if it's changed or not.

Edit: Well, that failed... haha, here is the suggestion i wanted to make to nb.json
Before:

  "process_editor.configuration_panel_data_model_selection_description": "Velg en datamodell å knytte til prosessteget",
  "process_editor.configuration_panel_data_model_selection_description_existing_model": "Du har allerede valgt en datamodell. Hvis du har brukt denne datamodellen i et skjema, kan du få ugyldige knytninger til datamodellfelt i skjemaet. Du får en feilmelding om hvilke felter det gjelder, i forhåndsvisningen",

After:

  "process_editor.configuration_panel_data_model_selection_description": "Velg en datamodell å knytte til prosessteget.",
  "process_editor.configuration_panel_data_model_selection_description_existing_model": "Du har allerede valgt en datamodell. Hvis du har brukt denne datamodellen i et skjema, kan du få ugyldige knytninger til datamodellfelt i skjemaet. Du får en feilmelding om hvilke felter det gjelder, i forhåndsvisningen.",

[nkylstad]

Nice! It works as expected 😄 I've added a suggestion, but it's up to you if it's changed or not.

Thanks for the suggestion! I decided to leave it as-is, because I think that is consistent with the other texts with the other description texts we use (although we don't have that many description texts yet). The question of punctuation at the end of descriptions in general might be something @Ildest has some thoughts on 😊

[Ildest]

Yes @nkylstad I have actually noted that as a discussion point with the other content designer for next week. I have seen titles with or without a full stop, texts next to checkboxes with the same inconsequence, etc. So we content designers will discuss and agree on when and where to have punctuation in UI texts and come back wit some recommendations.

For my suggestion in this issue, I can see that I have left out the full stop at the end of the last sentence, so thank you for inserting that @Konrad-Simso @nkylstad :-D.