feat: 13614 nextrecommendedaction in config column when adding a subform to select a subform from list #13827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
2 tasks
github-actions
bot
added
area/ui-editor
JamalAlabdullah
changed the title
JamalAlabdullah
changed the title
JamalAlabdullah
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13827 +/- ##
=======================================
Coverage 95.29% 95.29%
=======================================
Files 1653 1653
Lines 22024 22030 +6
Branches 2589 2594 +5
=======================================
+ Hits 20988 20994 +6
Misses 790 790
Partials 246 246 ☔ View full report in Codecov by Sentry. |
lassopicasso
requested changes
Oct 23, 2024
There was a problem hiding this comment.
Well done @JamalAlabdullah 💪
This is a nice solution, I just has some comments 🙂
frontend/packages/ux-editor/src/components/Properties/Properties.test.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/ux-editor/src/components/Properties/Properties.test.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/ux-editor/src/components/Properties/Properties.test.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/ux-editor/src/components/Properties/Properties.tsx
Outdated
Show resolved
Hide resolved
...mponents/Properties/PropertiesHeader/EditLayoutSetForSubform/EditLayoutSet/EditLayoutSet.tsx
Show resolved
Hide resolved
...mponents/Properties/PropertiesHeader/EditLayoutSetForSubform/EditLayoutSet/EditLayoutSet.tsx
Outdated
Show resolved
Hide resolved
...s/PropertiesHeader/EditLayoutSetForSubform/EditLayoutSet/SelectLayoutSet/SelectLayoutSet.tsx
Show resolved
Hide resolved
...ponents/Properties/PropertiesHeader/EditLayoutSetForSubform/EditLayoutSetForSubform.test.tsx
Show resolved
Hide resolved
lassopicasso
requested changes
Oct 24, 2024
There was a problem hiding this comment.
This looks good, @JamalAlabdullah 💪 Just one more small adjustment if you agree.
Jondyr
requested changes
Oct 24, 2024
…olumn-when-adding-a-subform-to-select-a-subform-from-list
…adding-a-subform-to-select-a-subform-from-list' of https://github.com/Altinn/altinn-studio into feat/13614-nextrecommendedaction-in-config-column-when-adding-a-subform-to-select-a-subform-from-list
Jondyr
approved these changes
Oct 24, 2024
JamalAlabdullah
deleted the
feat/13614-nextrecommendedaction-in-config-column-when-adding-a-subform-to-select-a-subform-from-list
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
nextrecommendedAction.mp4
Related Issue(s)
Verification
Documentation