Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Exclude null props in layout sets response #13841

Merged
merged 2 commits into from
Oct 22, 2024

Conversation

lassopicasso
Copy link
Contributor

Description

When fetching layout sets, we previously did not account for cases where the type or tasks properties were set to null. These properties should not be included in the JSON response when they are null. This issue has been resolved by adding the [UseSystemTextJson] annotation.

Before this fix, the following message would appear in the preview when the issue occurred:
image

And with the response:
image

Related Issue(s)

  • #{issue number}

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@lassopicasso lassopicasso added kind/bug Used when there is a defect / something is not working as it should. area/app-preview Area: Related to test and preview of apps that are developed in Altinn Studio. team/studio-domain2 labels Oct 22, 2024
@github-actions github-actions bot added solution/studio/designer Issues related to the Altinn Studio Designer solution. backend labels Oct 22, 2024
@Jondyr Jondyr added the skip-releasenotes Issues that do not make sense to list in our release notes label Oct 22, 2024
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.30%. Comparing base (5c1e97e) to head (c053d2d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13841   +/-   ##
=======================================
  Coverage   95.30%   95.30%           
=======================================
  Files        1652     1652           
  Lines       21980    21980           
  Branches     2585     2585           
=======================================
  Hits        20947    20947           
  Misses        787      787           
  Partials      246      246           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@JamalAlabdullah JamalAlabdullah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ok in dev

@JamalAlabdullah JamalAlabdullah merged commit e5f5c69 into main Oct 22, 2024
25 checks passed
@JamalAlabdullah JamalAlabdullah deleted the fix-preview-for-subform branch October 22, 2024 12:18
@JamalAlabdullah JamalAlabdullah removed their assignment Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
added-to-sprint area/app-preview Area: Related to test and preview of apps that are developed in Altinn Studio. backend kind/bug Used when there is a defect / something is not working as it should. skip-releasenotes Issues that do not make sense to list in our release notes solution/studio/designer Issues related to the Altinn Studio Designer solution. team/studio-domain2
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants