-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 13818 create StudioContentMenu #13847
Conversation
68e7dcd
to
7d95a94
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13847 +/- ##
==========================================
- Coverage 95.29% 95.28% -0.01%
==========================================
Files 1653 1653
Lines 22024 22022 -2
Branches 2589 2586 -3
==========================================
- Hits 20988 20984 -4
- Misses 790 793 +3
+ Partials 246 245 -1 ☔ View full report in Codecov by Sentry. |
Great job implementing this new
As our focus these days are smaller PRs and splitting the them, I suggest splitting this PR into 4 PRs based on the list I wrote above 😄 It will then be easier to review the code, and test the different areas separately. And other reason is so the relevant sub-teams (core, domain2, and resourceadm) will be able to review and test the code in «their area» without affecting each other 😄 |
7d95a94
to
32a03c1
Compare
Can try to do so! |
32a03c1
to
42ad227
Compare
Here is the first: #13898 |
Great @standeren 😄 I'll take a look at it asap 🚀 |
Yes, but wont those need to include the changes in the first one anyway? Of course I can merge with main when the contentMenu is merged. I'll see what I find best to do! |
Closing this one in favor of multiple, smaller PR's; |
Description
Create StudioContentMenu as a reusable component across SettingsModal, ResourceAdm and soon in ContentLibrary.
Settingsmodal
Old menu in settingsmodal:
New menu in settingsmodal:
ResourceAdm
Old menu in ResourceAdm:
New menu in ResourceAdm:
Related Issue(s)
Verification