Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Move useOnUnmount to dataModelling #13911

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

wrt95
Copy link
Contributor

@wrt95 wrt95 commented Oct 24, 2024

Description

  • only used in datamodelling, so it is moved there

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

@wrt95 wrt95 linked an issue Oct 24, 2024 that may be closed by this pull request
@github-actions github-actions bot added area/data-modeling Area: Related to data models - e.g. create, edit, use data models. solution/studio/designer Issues related to the Altinn Studio Designer solution. frontend labels Oct 24, 2024
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.29%. Comparing base (9ec0e3b) to head (fe177fe).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13911      +/-   ##
==========================================
- Coverage   95.29%   95.29%   -0.01%     
==========================================
  Files        1653     1651       -2     
  Lines       22030    22025       -5     
  Branches     2594     2595       +1     
==========================================
- Hits        20994    20989       -5     
  Misses        790      790              
  Partials      246      246              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@framitdavid framitdavid added skip-manual-testing PRs that do not need to be tested manually and removed skip-manual-testing PRs that do not need to be tested manually labels Oct 25, 2024
@framitdavid framitdavid merged commit 239d06f into main Oct 25, 2024
10 checks passed
@framitdavid framitdavid deleted the 13870-move-useOnUnmount-to-dataModelling branch October 25, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/data-modeling Area: Related to data models - e.g. create, edit, use data models. frontend solution/studio/designer Issues related to the Altinn Studio Designer solution. team/studio-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move useOnUnmount to dataModelling
2 participants