Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Move useWebSocket to app-development #13912

Merged
merged 3 commits into from
Oct 30, 2024

Conversation

wrt95
Copy link
Contributor

@wrt95 wrt95 commented Oct 24, 2024

Description

  • Only used in app-development so the hook is moved there

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

@wrt95 wrt95 linked an issue Oct 24, 2024 that may be closed by this pull request
@github-actions github-actions bot added solution/studio/designer Issues related to the Altinn Studio Designer solution. frontend labels Oct 24, 2024
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.13%. Comparing base (bea682e) to head (3d91f21).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13912   +/-   ##
=======================================
  Coverage   95.13%   95.13%           
=======================================
  Files        1677     1678    +1     
  Lines       22238    22239    +1     
  Branches     2612     2612           
=======================================
+ Hits        21157    21158    +1     
  Misses        835      835           
  Partials      246      246           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wrt95 wrt95 added the skip-manual-testing PRs that do not need to be tested manually label Oct 25, 2024
@framitdavid
Copy link
Collaborator

Tested OK in dev

@framitdavid framitdavid merged commit 7c1ce6d into main Oct 30, 2024
17 checks passed
@framitdavid framitdavid deleted the 13871-move-useWebSocket-to-app-development branch October 30, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend skip-manual-testing PRs that do not need to be tested manually solution/studio/designer Issues related to the Altinn Studio Designer solution. team/studio-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move useWebSocket to app-development
2 participants