Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: replace AltinnContentLoader with StudioSpinner and delete react-content-loader dependency #13958

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: replace AltinnContentLoader with StudioSpinner and delete react-content-loader dependency #13958

wants to merge 1 commit into from
+4 −75

Conversation

standeren
Copy link
Contributor

@standeren standeren commented Oct 31, 2024 •
edited
Loading

Description

Replace and delete AltinnContentLoader with StudioSpinner and delete react-content-loader dependency

Skjermopptak.2024-10-31.kl.12.30.30.mov

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)

@standeren standeren added the skip-releasenotes Issues that do not make sense to list in our release notes label Oct 31, 2024
@standeren standeren linked an issue Oct 31, 2024 that may be closed by this pull request
Replace AltinnContentLoader with StudioSpinner #13955
Open
2 tasks
@github-actions github-actions bot added area/app-deploy Area: Related to deploying apps from Altinn Studio to Altinn Apps. solution/studio/designer Issues related to the Altinn Studio Designer solution. kind/dependencies Used for issues or pull requests that are dependency updates frontend labels Oct 31, 2024
@standeren standeren changed the title Replace AltinnContentLoader with StudioSpinner and delete react-content-loader dependency fix: replace AltinnContentLoader with StudioSpinner and delete react-content-loader dependency Oct 31, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.19%. Comparing base (fad4b91) to head (a64a53b).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #13958      +/-   ##
==========================================
- Coverage   95.19%   95.19%   -0.01%     
==========================================
  Files        1694     1692       -2     
  Lines       22445    22437       -8     
  Branches     2630     2629       -1     
==========================================
- Hits        21366    21358       -8     
  Misses        834      834              
  Partials      245      245

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/app-deploy Area: Related to deploying apps from Altinn Studio to Altinn Apps. frontend kind/dependencies Used for issues or pull requests that are dependency updates skip-releasenotes Issues that do not make sense to list in our release notes solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace AltinnContentLoader with StudioSpinner
1 participant
@standeren