chore: Replace divider component #13960
Conversation
github-actions
bot
added
area/data-modeling
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13960 +/- ##
==========================================
- Coverage 95.19% 95.19% -0.01%
==========================================
Files 1697 1698 +1
Lines 22457 22450 -7
Branches 2631 2630 -1
==========================================
- Hits 21378 21371 -7
Misses 834 834
Partials 245 245 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
I see that the deleteButton class is still referenced in the CustomProperties component. Can we also delete the class from there? 😄
| </> | ||
| )} | ||
| {hasCustomProps && <CustomProperties path={schemaPointer} />} |
There was a problem hiding this comment.
Will it be a divider between the rootPointer and the customProps now? Looks like this change only sets a divider in the top of the FieldSet below this component? 🤔
There was a problem hiding this comment.
Probably no biggie, but it looks like the Divider above the FieldSet is lost now? If it is not added css to the FieldSet component that sets a border on the top of it 🫣
| <StudioLabelAsParagraph size='sm' className={classes.noItem}> | ||
| {t('schema_editor.no_item_selected')} | ||
| </StudioLabelAsParagraph> |
There was a problem hiding this comment.
Maybe this could be moved to a separate file so we dont need to duplicate the noItem css in two files? 😊
Then we can use it both here and in TypeInspector
Description
<Divider />component.Related Issue(s)
Dividerwithborder-bottom: solid {X} px {color}#13877Verification