Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Validate create subform in nextrecommendedaction #13966

Merged
merged 5 commits into from
Nov 4, 2024

Conversation

lassopicasso
Copy link
Contributor

@lassopicasso lassopicasso commented Nov 1, 2024

Description

  • This PR introduces validation for creating a new subform within the recommended next action container for the subform component in the main layout set.
Video of this PR

Receives an error after creating, this is also in main, new issue here: #13967

validationcreatesubform.mp4
  • Additionally, I have implemented a reusable hook, useCreateSubform, to facilitate subform creation. This hook includes specific parameters, such as the "subform" string, and is used in a couple of places.

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@github-actions github-actions bot added area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution. frontend labels Nov 1, 2024
Copy link

codecov bot commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.21%. Comparing base (5a3082b) to head (0649363).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13966   +/-   ##
=======================================
  Coverage   95.20%   95.21%           
=======================================
  Files        1701     1702    +1     
  Lines       22519    22525    +6     
  Branches     2638     2638           
=======================================
+ Hits        21440    21447    +7     
+ Misses        833      832    -1     
  Partials      246      246           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lassopicasso lassopicasso changed the title Validate create subform in nextrecommendedaction feat: Validate create subform in nextrecommendedaction Nov 1, 2024
@lassopicasso lassopicasso marked this pull request as ready for review November 1, 2024 14:10
Copy link
Contributor

@JamalAlabdullah JamalAlabdullah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works nice👍

Copy link
Contributor

@JamalAlabdullah JamalAlabdullah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice jobb 🚀

Copy link
Member

@Jondyr Jondyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well 👍 ✅

@Jondyr Jondyr merged commit 0c25d8e into main Nov 4, 2024
17 checks passed
@Jondyr Jondyr deleted the validate-create-subform-in-nextrecommendedaction branch November 4, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. frontend solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add validation for creating a new subform input in StudioCard/ nextRecommendAction
3 participants