-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Validate create subform in nextrecommendedaction #13966
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13966 +/- ##
=======================================
Coverage 95.20% 95.21%
=======================================
Files 1701 1702 +1
Lines 22519 22525 +6
Branches 2638 2638
=======================================
+ Hits 21440 21447 +7
+ Misses 833 832 -1
Partials 246 246 ☔ View full report in Codecov by Sentry. |
...ditLayoutSetForSubform/EditLayoutSet/CreateNewSubformLayoutSet/CreateNewSubformLayoutSet.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works nice👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice jobb 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well 👍 ✅
Description
Video of this PR
Receives an error after creating, this is also in main, new issue here: #13967
validationcreatesubform.mp4
useCreateSubform
, to facilitate subform creation. This hook includes specific parameters, such as the "subform" string, and is used in a couple of places.Related Issue(s)
Verification
Documentation