Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use object type for option value and custom converter to restrict invalid types #13968

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: Use object type for option value and custom converter to restrict invalid types #13968

wants to merge 2 commits into from
+126 −8

Conversation

standeren
Copy link
Contributor

@standeren standeren commented Nov 1, 2024 •
edited
Loading

Description

Use object type for option value and custom converter to restrict invalid types

Related Issue(s)

  • #{issue number}

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

@standeren standeren linked an issue Nov 1, 2024 that may be closed by this pull request
Option model class should support strings, numbers and booleans #13926
Open
@github-actions github-actions bot added solution/studio/designer Issues related to the Altinn Studio Designer solution. backend labels Nov 1, 2024
@standeren standeren changed the title Use object type for option value and custom converter to restrict invalid types bug: Use object type for option value and custom converter to restrict invalid types Nov 1, 2024
@standeren standeren changed the title bug: Use object type for option value and custom converter to restrict invalid types fix: Use object type for option value and custom converter to restrict invalid types Nov 1, 2024
@standeren standeren marked this pull request as ready for review November 1, 2024 15:12
@github-actions github-actions bot added the quality/testing Tests that are missing, needs to be created or could be improved. label Nov 1, 2024
@standeren standeren force-pushed the bug/allow-bool-and-numeric-values-in-options branch 2 times, most recently from 3628bfd to 774f0d3 Compare November 1, 2024 15:14
@standeren standeren force-pushed the bug/allow-bool-and-numeric-values-in-options branch from 774f0d3 to 41c1ea0 Compare November 2, 2024 07:34
ErlingHauan
ErlingHauan approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@ErlingHauan ErlingHauan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ErlingHauan ErlingHauan ErlingHauan approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
backend quality/testing Tests that are missing, needs to be created or could be improved. solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Option model class should support strings, numbers and booleans
2 participants
@standeren @ErlingHauan