Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add typeName check for AnyURI mapped to string in csharp #13969

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Add typeName check for AnyURI mapped to string in csharp #13969

wants to merge 1 commit into from
+39 −0

Conversation

standeren
Copy link
Contributor

Description

Add typeName check for AnyURI mapped to string in csharp
Add testcase

Related Issue(s)

  • #{issue number}

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

@standeren standeren linked an issue Nov 3, 2024 that may be closed by this pull request
Using format: URI for string property in data model causes data model generation to fail #13731
Open
@github-actions github-actions bot added area/data-modeling Area: Related to data models - e.g. create, edit, use data models. solution/studio/designer Issues related to the Altinn Studio Designer solution. quality/testing Tests that are missing, needs to be created or could be improved. backend labels Nov 3, 2024
@standeren standeren changed the title Add typeName check for AnyURI mapped to string in csharp fix(datamodeling): Add typeName check for AnyURI mapped to string in csharp Nov 3, 2024
@standeren standeren changed the title fix(datamodeling): Add typeName check for AnyURI mapped to string in csharp fix: Add typeName check for AnyURI mapped to string in csharp Nov 3, 2024
@standeren standeren force-pushed the 13731-using-format-uri-for-string-property-in-data-model-causes-data-model-generation-to-fail branch 2 times, most recently from fc35afa to 8b933fd Compare November 4, 2024 06:56
@github-actions github-actions bot added the skip-releasenotes Issues that do not make sense to list in our release notes label Nov 4, 2024
@standeren standeren force-pushed the 13731-using-format-uri-for-string-property-in-data-model-causes-data-model-generation-to-fail branch from 8b933fd to 4904d81 Compare November 4, 2024 07:01
@codecov Codecov
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.20%. Comparing base (d1bb949) to head (4904d81).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #13969   +/-   ##
=======================================
  Coverage   95.20%   95.20%           
=======================================
  Files        1701     1701           
  Lines       22519    22519           
  Branches     2638     2638           
=======================================
  Hits        21440    21440           
  Misses        833      833           
  Partials      246      246

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ErlingHauan
ErlingHauan approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@ErlingHauan ErlingHauan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great that you added a test case for this 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ErlingHauan ErlingHauan ErlingHauan approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
area/data-modeling Area: Related to data models - e.g. create, edit, use data models. backend quality/testing Tests that are missing, needs to be created or could be improved. skip-releasenotes Issues that do not make sense to list in our release notes solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using format: URI for string property in data model causes data model generation to fail
2 participants
@standeren @ErlingHauan