Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: xsd:all support #13974

Merged
merged 5 commits into from
Nov 4, 2024
Merged

feat: xsd:all support #13974

merged 5 commits into from
Nov 4, 2024

Conversation

mirkoSekulic
Copy link
Collaborator

@mirkoSekulic mirkoSekulic commented Nov 4, 2024 •
edited
Loading

Description

Support for xs:all is supported in the pr in one direction
xsd -> json -> c# .
Note that round conversion is not supported.

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@github-actions github-actions bot added area/data-modeling Area: Related to data models - e.g. create, edit, use data models. solution/studio/designer Issues related to the Altinn Studio Designer solution. quality/testing Tests that are missing, needs to be created or could be improved. skip-releasenotes Issues that do not make sense to list in our release notes backend labels Nov 4, 2024
@mirkoSekulic mirkoSekulic marked this pull request as draft November 4, 2024 12:35
@mirkoSekulic mirkoSekulic linked an issue Nov 4, 2024 that may be closed by this pull request
Support xsd:all when generating model from xsd schema #13945
Closed
@mirkoSekulic mirkoSekulic marked this pull request as ready for review November 4, 2024 12:52
@mirkoSekulic mirkoSekulic marked this pull request as draft November 4, 2024 12:54
@mirkoSekulic mirkoSekulic marked this pull request as ready for review November 4, 2024 13:09
@mirkoSekulic mirkoSekulic added skip-manual-testing PRs that do not need to be tested manually and removed skip-releasenotes Issues that do not make sense to list in our release notes labels Nov 4, 2024
framitdavid
framitdavid approved these changes Nov 4, 2024
View reviewed changes
Copy link
Collaborator

@framitdavid framitdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@mirkoSekulic mirkoSekulic merged commit 18d21a0 into main Nov 4, 2024
11 checks passed
@mirkoSekulic mirkoSekulic deleted the feature/xsd-all branch November 4, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

@framitdavid framitdavid framitdavid approved these changes

Assignees
No one assigned
Labels
area/data-modeling Area: Related to data models - e.g. create, edit, use data models. backend quality/testing Tests that are missing, needs to be created or could be improved. skip-manual-testing PRs that do not need to be tested manually solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support xsd:all when generating model from xsd schema
2 participants
@mirkoSekulic @framitdavid