Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: adapt contract when fetching all option lists to visualize error per option list #14269

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

refactor: adapt contract when fetching all option lists to visualize error per option list #14269

wants to merge 3 commits into from

Conversation

standeren
Copy link
Contributor

@standeren standeren commented Dec 12, 2024 •
edited
Loading

Description

  • change contract in get all option lists endpoint in order to return all option lists, independent of being healthy or faulty. If faulty the data prop is swapped with the hasError prop.
Skjermbilde 2024-12-12 kl 10 52 48

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

@github-actions github-actions bot added area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution. backend frontend labels Dec 12, 2024
@standeren standeren force-pushed the imporove-error-handling-for-get-all-option-lists-endpoint branch from 13df12e to 9ef1ecd Compare December 12, 2024 10:07
@standeren standeren marked this pull request as draft December 12, 2024 10:12
@standeren standeren force-pushed the imporove-error-handling-for-get-all-option-lists-endpoint branch from 9ef1ecd to bf44f5a Compare December 12, 2024 10:13
@standeren standeren linked an issue Dec 12, 2024 that may be closed by this pull request
Fetch optionLists in individual requests #14122
Open
@standeren standeren force-pushed the imporove-error-handling-for-get-all-option-lists-endpoint branch 2 times, most recently from 0273996 to 6caaae9 Compare December 18, 2024 08:17
@github-actions github-actions bot added the quality/testing Tests that are missing, needs to be created or could be improved. label Dec 18, 2024
@standeren standeren force-pushed the imporove-error-handling-for-get-all-option-lists-endpoint branch from 6caaae9 to 180f682 Compare December 18, 2024 09:41
@standeren standeren force-pushed the imporove-error-handling-for-get-all-option-lists-endpoint branch 2 times, most recently from 38024da to efca53c Compare December 20, 2024 13:54
@standeren standeren force-pushed the imporove-error-handling-for-get-all-option-lists-endpoint branch from efca53c to 6988b6d Compare December 20, 2024 14:27
@codecov Codecov
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 97.91667% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.56%. Comparing base (cc8754c) to head (6988b6d).

Files with missing lines Patch % Lines
...s/ux-editor/src/components/Elements/ExportForm.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #14269   +/-   ##
=======================================
  Coverage   95.56%   95.56%           
=======================================
  Files        1843     1843           
  Lines       23886    23900   +14     
  Branches     2752     2754    +2     
=======================================
+ Hits        22827    22841   +14     
  Misses        802      802           
  Partials      257      257

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@standeren standeren marked this pull request as ready for review December 20, 2024 14:44
@standeren standeren added skip-releasenotes Issues that do not make sense to list in our release notes team/studio-domain1 skip-documentation Issues where updating documentation is not relevant labels Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. backend frontend quality/testing Tests that are missing, needs to be created or could be improved. skip-documentation Issues where updating documentation is not relevant skip-releasenotes Issues that do not make sense to list in our release notes solution/studio/designer Issues related to the Altinn Studio Designer solution. team/studio-domain1
Projects
Team Studio
Status: 🔎 Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fetch optionLists in individual requests
1 participant
@standeren