-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 13738 fix dotnet build warnings #14321
Open
standeren
wants to merge
7
commits into
main
Choose a base branch
from
13738-fix-dotnet-build-warnings
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/data-modeling
Area: Related to data models - e.g. create, edit, use data models.
solution/studio/designer
Issues related to the Altinn Studio Designer solution.
quality/testing
Tests that are missing, needs to be created or could be improved.
skip-releasenotes
Issues that do not make sense to list in our release notes
backend
kind/dependencies
Used for issues or pull requests that are dependency updates
labels
Dec 20, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14321 +/- ##
=======================================
Coverage 95.56% 95.56%
=======================================
Files 1843 1843
Lines 23886 23886
Branches 2752 2752
=======================================
Hits 22827 22827
Misses 802 802
Partials 257 257 ☔ View full report in Codecov by Sentry. |
standeren
added
team/studio-domain1
skip-documentation
Issues where updating documentation is not relevant
and removed
area/data-modeling
Area: Related to data models - e.g. create, edit, use data models.
labels
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backend
kind/dependencies
Used for issues or pull requests that are dependency updates
quality/testing
Tests that are missing, needs to be created or could be improved.
skip-documentation
Issues where updating documentation is not relevant
skip-releasenotes
Issues that do not make sense to list in our release notes
solution/studio/designer
Issues related to the Altinn Studio Designer solution.
team/studio-core
team/studio-domain1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#nullable enable
in the classes that had nullable fields.required
keyword in class fields that was not nullable but in a file that had#nullable enable
.ISystemClock
withTimeProvider
in options for authentication helper due to obsolete warning.Terminal when running
dotnet build
Related Issue(s)
Verification