Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 13738 fix dotnet build warnings #14321

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

standeren
Copy link
Contributor

@standeren standeren commented Dec 20, 2024

Description

  • Add some explicit package imports from transitive dependencies that were colliding with some of our packages.
  • Add some explicit package imports from transitive dependencies that needed upgrading due to security vulnerabilities.
  • Add #nullable enable in the classes that had nullable fields.
  • Add required keyword in class fields that was not nullable but in a file that had #nullable enable.
  • Add XML docs for arguments that did not have it.
  • Replaced ISystemClock with TimeProvider in options for authentication helper due to obsolete warning.

Terminal when running dotnet build
Skjermbilde 2024-12-20 kl  15 20 44

Related Issue(s)

  • #{issue number}

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)

@standeren standeren linked an issue Dec 20, 2024 that may be closed by this pull request
@github-actions github-actions bot added area/data-modeling Area: Related to data models - e.g. create, edit, use data models. solution/studio/designer Issues related to the Altinn Studio Designer solution. quality/testing Tests that are missing, needs to be created or could be improved. skip-releasenotes Issues that do not make sense to list in our release notes backend kind/dependencies Used for issues or pull requests that are dependency updates labels Dec 20, 2024
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.56%. Comparing base (cc8754c) to head (e644513).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14321   +/-   ##
=======================================
  Coverage   95.56%   95.56%           
=======================================
  Files        1843     1843           
  Lines       23886    23886           
  Branches     2752     2752           
=======================================
  Hits        22827    22827           
  Misses        802      802           
  Partials      257      257           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@standeren standeren added team/studio-domain1 skip-documentation Issues where updating documentation is not relevant and removed area/data-modeling Area: Related to data models - e.g. create, edit, use data models. labels Dec 20, 2024
@standeren standeren marked this pull request as ready for review December 20, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend kind/dependencies Used for issues or pull requests that are dependency updates quality/testing Tests that are missing, needs to be created or could be improved. skip-documentation Issues where updating documentation is not relevant skip-releasenotes Issues that do not make sense to list in our release notes solution/studio/designer Issues related to the Altinn Studio Designer solution. team/studio-core team/studio-domain1
Projects
Status: 🔎 Review
Development

Successfully merging this pull request may close these issues.

Fix dotnet build warnings
1 participant