Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DevTools: Improved the general tab layout #1306

Merged
merged 10 commits into from
Jul 20, 2023

Conversation

bjosttveit
Copy link
Member

@bjosttveit bjosttveit commented Jul 4, 2023

Description

This also includes an update to the design system to get the Chip component.

Made the layout more responsive so it actually uses the horizontal space, and added scrolling. Also added a warning message above the preview PDF button if not using google chrome. To make the navigation more responsive I used the new Chip component from the design system.

image

Screen.Recording.2023-07-05.at.11.01.35.mov

@bjosttveit bjosttveit marked this pull request as ready for review July 5, 2023 08:59
@bjosttveit bjosttveit added the kind/other Pull requests containing chores/repo structure/other changes label Jul 5, 2023
Copy link
Contributor

@olemartinorg olemartinorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@bjosttveit
Copy link
Member Author

Waiting a bit for clarification on design system button updates.

@bjosttveit bjosttveit marked this pull request as draft July 5, 2023 12:03
@bjosttveit bjosttveit self-assigned this Jul 5, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jul 20, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

19.2% 19.2% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@bjosttveit bjosttveit marked this pull request as ready for review July 20, 2023 11:53
@bjosttveit bjosttveit merged commit b03d28c into main Jul 20, 2023
8 of 9 checks passed
@bjosttveit bjosttveit deleted the dev-tools-general-improvement branch July 20, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/other Pull requests containing chores/repo structure/other changes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants