Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug for auto save behavior on change page #1314

Merged
merged 1 commit into from
Jul 7, 2023

Conversation

lasseklovstad
Copy link
Contributor

@lasseklovstad lasseklovstad commented Jul 6, 2023

Description

When saving formData for statefull app the http request was not cancelled if the saga was cancelled (takeLatest). This would lead to the user beeing stuck on the same page if the Naviagtion was triggered two times in a row on slow internett.

Related Issue(s)

Verification/QA

  • Manual functionality testing
    • I have tested these changes manually
    • Creator of the original issue (or service owner) has been contacted for manual testing (or will be contacted when released in alpha)
    • No testing done/necessary
  • Automated tests
    • Unit test(s) have been added/updated
    • Cypress E2E test(s) have been added/updated
    • No automatic tests are needed here (no functional changes/additions)
    • I want someone to help me make some tests
  • UU/WCAG (follow these guidelines until we have our own)
    • I have tested with a screen reader/keyboard navigation/automated wcag validator
    • No testing done/necessary (no DOM/visual changes)
    • I want someone to help me perform accessibility testing
  • User documentation @ altinn-studio-docs
    • Has been added/updated
    • No functionality has been changed/added, so no documentation is needed
    • I will do that later/have created an issue
  • Changes/additions to component properties
    • Changes are reflected in both src/layout/layout.d.ts and layout.schema.v1.json, and these are all backwards-compatible
    • No changes made
  • Support in Altinn Studio
    • Issue(s) created for support in Studio
    • This change/feature does not require any changes to Altinn Studio
  • Sprint board
    • The original issue (or this PR itself) has been added to the Team Apps project and to the current sprint board
    • I don't have permissions to do that, please help me out
  • Labels
    • I have added a kind/* label to this PR for proper release notes grouping
    • I don't have permissions to add labels, please help me out

@lasseklovstad lasseklovstad changed the title Fix bug: Cancel request when saga is cancelled and set saving to false Fix bug for auto save behavior on change page Jul 6, 2023
Copy link
Member

@bjosttveit bjosttveit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 🥇

@bjosttveit bjosttveit merged commit c09cc43 into Altinn:main Jul 7, 2023
@bjosttveit bjosttveit added external-contribution-❤️ Pull request from a developer outside the Altinn teams. kind/bug Something isn't working labels Jul 7, 2023
@bjosttveit
Copy link
Member

Reproduced the issue and confirmed it is fixed 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external-contribution-❤️ Pull request from a developer outside the Altinn teams. kind/bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

AutoSaveBehavior: OnChangePage double click next button doesn't navigate
2 participants