-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CSS injection order #1330
Merged
Merged
Fix CSS injection order #1330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjosttveit
added
the
kind/other
Pull requests containing chores/repo structure/other changes
label
Jul 13, 2023
Set as draft until I fix the visual changes |
SonarCloud Quality Gate failed. 1 Bug 60.5% Coverage Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
olemartinorg
approved these changes
Jul 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Phenomenal work!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is the only way I could find to fix the issues with CSS specificity, see the original issue for an explanation. This will override the
document.head.appendChild
method to injectstyle
elements before anylink
elements. This means we no longer need to use!important
or unecessarily great specificity to override styles from external libraries likematerial-ui
and@digdir/design-system-react
.I also cleaned up the use of
!important
where I could.Since our own css is now higher priority, this also means that the old
tjenester3.css
now more often gets applied over library styles, therefore a lot of cleanup in this file (-4000 lines) and affected components was necessary. This is a step in the right direction of getting rid of the old global css and the old font-icons. Whenever I broke an old component relying ontjenester3.css
, I replaced them with design system components and nav icons instead of fixing them, so there are some visual updates as well.Related Issue(s)
Verification/QA
src/layout/layout.d.ts
andlayout.schema.v1.json
, and these are all backwards-compatiblekind/*
label to this PR for proper release notes grouping