Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panel Component #2674

Merged
merged 14 commits into from
Nov 5, 2024
Merged

Panel Component #2674

merged 14 commits into from
Nov 5, 2024

Conversation

cammiida
Copy link
Contributor

@cammiida cammiida commented Oct 31, 2024

Description

New dumb Panel component.

Related Issue(s)

  • closes #{issue number}

Verification/QA

  • Manual functionality testing
    • I have tested these changes manually
    • Creator of the original issue (or service owner) has been contacted for manual testing (or will be contacted when released in alpha)
    • No testing done/necessary
  • Automated tests
    • Unit test(s) have been added/updated
    • Cypress E2E test(s) have been added/updated
    • No automatic tests are needed here (no functional changes/additions)
    • I want someone to help me make some tests
  • UU/WCAG (follow these guidelines until we have our own)
    • I have tested with a screen reader/keyboard navigation/automated wcag validator
    • No testing done/necessary (no DOM/visual changes)
    • I want someone to help me perform accessibility testing
  • User documentation @ altinn-studio-docs
    • Has been added/updated
    • No functionality has been changed/added, so no documentation is needed
    • I will do that later/have created an issue
  • Support in Altinn Studio
    • Issue(s) created for support in Studio
    • This change/feature does not require any changes to Altinn Studio
  • Sprint board
    • The original issue (or this PR itself) has been added to the Team Apps project and to the current sprint board
    • I don't have permissions to do that, please help me out
  • Labels
    • I have added a kind/* label to this PR for proper release notes grouping
    • I don't have permissions to add labels, please help me out

@cammiida cammiida added the kind/other Pull requests containing chores/repo structure/other changes label Oct 31, 2024
@cammiida cammiida marked this pull request as ready for review October 31, 2024 15:00
Copy link

sonarcloud bot commented Nov 4, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
33.33% Condition Coverage on New Code (required ≥ 45%)

See analysis details on SonarCloud

Copy link
Member

@bjosttveit bjosttveit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@cammiida cammiida merged commit c7a66b8 into main Nov 5, 2024
8 of 9 checks passed
@cammiida cammiida deleted the feature/panel branch November 5, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/designsystem kind/other Pull requests containing chores/repo structure/other changes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants