Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing frequent re-renders with latest app-lib-dotnet #2683

Merged
merged 3 commits into from
Nov 5, 2024

Conversation

olemartinorg
Copy link
Contributor

Description

In the latest app-lib-dotnet, the backend sends us updated instance data after saving form data. Great stuff, which will fix some issues we've had, but this made some of our greedy selectors re-render components too often, which also at some point caused duplicate components to show up in a repeating group (because the node hierarchy got forcefully re-rendered). This fixes the root cause, but later I'll also open a PR with a fix that makes sure that exact thing cannot happen again even despite re-rendering.

Related Issue(s)

Verification/QA

  • Manual functionality testing
    • I have tested these changes manually
    • Creator of the original issue (or service owner) has been contacted for manual testing (or will be contacted when released in alpha)
    • No testing done/necessary
  • Automated tests
    • Unit test(s) have been added/updated
    • Cypress E2E test(s) have been added/updated
    • No automatic tests are needed here (no functional changes/additions)
    • I want someone to help me make some tests
  • UU/WCAG (follow these guidelines until we have our own)
    • I have tested with a screen reader/keyboard navigation/automated wcag validator
    • No testing done/necessary (no DOM/visual changes)
    • I want someone to help me perform accessibility testing
  • User documentation @ altinn-studio-docs
    • Has been added/updated
    • No functionality has been changed/added, so no documentation is needed
    • I will do that later/have created an issue
  • Support in Altinn Studio
    • Issue(s) created for support in Studio
    • This change/feature does not require any changes to Altinn Studio
  • Sprint board
    • The original issue (or this PR itself) has been added to the Team Apps project and to the current sprint board
    • I don't have permissions to do that, please help me out
  • Labels
    • I have added a kind/* label to this PR for proper release notes grouping
    • I don't have permissions to add labels, please help me out

Ole Martin Handeland added 2 commits November 5, 2024 09:26
…ime (after each save) and caused all nodes to re-render and unmount (removing them in the process, and probably damaging the NodesContext).
@olemartinorg olemartinorg added the kind/bug Something isn't working label Nov 5, 2024
Copy link

sonarcloud bot commented Nov 5, 2024

@olemartinorg olemartinorg merged commit 41f43ad into main Nov 5, 2024
9 checks passed
@olemartinorg olemartinorg deleted the bug/instance-data-rerenders branch November 5, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants