Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[V8] Add [Authorize] attribute on AuthorizationController.GetCurrentParty #338

Merged
merged 1 commit into from
Nov 15, 2023
Merged

[V8] Add [Authorize] attribute on AuthorizationController.GetCurrentParty #338

merged 1 commit into from
Nov 15, 2023

Conversation

ivarne
Copy link
Member

@ivarne ivarne commented Nov 6, 2023

This means that the code won't crash with missing cookie when the cookie exipires

Description

Not sure how to actually test this.

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@ivarne
Add [Authorize] attribute on AuthorizationController.GetCurrentParty
14b7483 
This means that the code won't crash with missing cookie when the cookie
exipires
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ivarne ivarne requested a review from tjololo November 13, 2023 09:24
tjololo
tjololo approved these changes Nov 15, 2023
View reviewed changes
Copy link
Member

@tjololo tjololo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have included a fix for the flaky tests in the "magic button" branch. If I don't get to merge it soon I will provide it in a separate PR

@ivarne ivarne merged commit 98f8613 into v8 Nov 15, 2023
10 checks passed
@ivarne ivarne deleted the ivarne/authroize_getCurrentParty branch November 15, 2023 11:15
@tjololo tjololo added the bugfix Label Pull requests with bugfix. Used when generation releasenotes label Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjololo tjololo tjololo approved these changes

Assignees
No one assigned
Labels
bugfix Label Pull requests with bugfix. Used when generation releasenotes
Projects
Team Apps
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ivarne @tjololo