Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monorepo ADR #972

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Monorepo ADR #972

wants to merge 2 commits into from

Conversation

adamhaeger
Copy link
Contributor

Description

Adds a separate ADR for monorepo that builds on the SDLC ADR.

Copy link
Contributor

@martinothamar martinothamar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this addresses the why but not the how. Is that also the topic for ADRs?

  • What should the repo be called
  • Migration of issues
  • Migration of code (what to do about git history)
  • Migration of GitHub Actions workflows

- Can be mitigated with good tooling and documentation.
- Risk of larger PRs containing frontend and backend changes, potentially complicating reviews.
- Can be mitigated by having multiple people review if necessary, keep PRs specific.
- Higher potential for repository-wide issues affecting multiple areas.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 repo with issues related to both frontend and backend - is that an issue? I think it's fine, but maybe we can have area/ labels or someting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants