Fix a few issues with the Dockerfile #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I tried to work on some sort of automated testing and ran into a really strange issue with dotnet in docker. The docker container did not work with `--env DOTNET_ENVIRONMENT=Development`. After lots of guesswork I found that deleting the `wwwroot` folder fixed the issue. It turns out that when you do a separate `build` step it generates `App.staticwebassets.runtime.json` with full absolute path to the `wwwroot` folder, and it gets included in the `publish` result. In the `build` step the path is `/App/wwwroot`, but in final the name was `/app/wwwroot`. This fixes 3 issues * A separate `restore` step makes for faster iteration when building repeatedly locally. * Consistent folder name `app` vs `App` in build container vs final container * A separate `dotnet build` step doesn't really make much sense, and the resulting `App.staticwebassets.runtime.json` is apparently just causing issues.
tjololo
added
the
external-contribution-❤️
tjololo
approved these changes
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm opening this mainly because I want to give a heads up on these issues. I'm not in a hurry to have this merged, but it seems wasteful to not share the painful experience of figuring out this.
I tried to work on some sort of automated testing and ran into a really strange issue with dotnet in docker. The docker container did not work with
--env DOTNET_ENVIRONMENT=Development. After lots of guesswork I found that deleting thewwwrootfolder fixed the issue. It turns out that when you do a separatebuildstep it generatesApp.staticwebassets.runtime.jsonwith full absolute path to thewwwrootfolder, and it gets included in thepublishresult. In thebuildstep the path is/App/wwwroot, but in final the name was/app/wwwroot.This fixes 3 issues
restorestep makes for faster iteration when building repeatedly locally without downloading dependencies.appvsAppin build container vs final containerdotnet buildstep doesn't really make much sense, and the resultingApp.staticwebassets.runtime.jsonis apparently just causing issues.