add tests on BitwiseOp::Shl #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #13 +/- ##
========================================
+ Coverage 15.6% 16.2% +0.6%
========================================
Files 10 10
Lines 2271 2271
========================================
+ Hits 354 368 +14
+ Misses 1917 1903 -14 see 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
6293
commented
Jun 28, 2023
tests/asm.rs
Outdated
| eq.n r8192[0],r8192[2]; | ||
| ret; | ||
| } | ||
| // FIXME shift value is limited to 1024 |
6293
force-pushed
the
test-shl
branch
3 times, most recently
from
aff0e33
to
bf3b1d0
Compare
dr-orlovsky
reviewed
Jul 5, 2023
src/pipelines/compiler.rs
Outdated
| @@ -505,6 +505,7 @@ impl<'i> Statement<'i> { | |||
| } | |||
|
|
|||
| fn goto(&'i self, no: u8, issues: &mut Issues<'i, issues::Compile>) -> Option<String> { | |||
| println!("aaaaaaaaaaaa {:?}", self.operands.get(0)); | |||
There was a problem hiding this comment.
I think we need to remove this
src/pipelines/compiler.rs
Outdated
| @@ -529,7 +530,7 @@ impl<'i> Statement<'i> { | |||
| SemanticError::OperandMissed { | |||
| operator: self.operator.0, | |||
| pos: no + 1, | |||
| expected: "goto statement", | |||
| expected: "goto statemelllnt", | |||
There was a problem hiding this comment.
Looks like a typo / accidental change
|
Why do the tests are failing? |
|
dependent on AluVM/rust-aluvm#91 |
|
With AluVM/rust-aluvm#91 merged we can rebase now and then I will merge this |
|
rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.