test: add tests and fix accessibility issues for the select #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbasso
force-pushed
the
select-accessibility
branch
2 times, most recently
from
1d55038
to
6af8f4e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #462 +/- ##
==========================================
- Coverage 91.64% 89.90% -1.74%
==========================================
Files 101 108 +7
Lines 2249 3954 +1705
Branches 406 797 +391
==========================================
+ Hits 2061 3555 +1494
- Misses 119 397 +278
+ Partials 69 2 -67
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
fbasso
force-pushed
the
select-accessibility
branch
from
6af8f4e
to
d54d780
Compare
ExFlo
reviewed
Feb 15, 2024
fbasso
force-pushed
the
select-accessibility
branch
2 times, most recently
from
3e810f3
to
ceacbdb
Compare
fbasso
force-pushed
the
select-accessibility
branch
from
ceacbdb
to
8a58ec5
Compare
|
@quentinderoubaix, pushed again with changes. |
quentinderoubaix
approved these changes
Feb 20, 2024
fbasso
force-pushed
the
select-accessibility
branch
from
8a58ec5
to
0991f2a
Compare
|
Thanks @quentinderoubaix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #459
fix #263