Add version detection for stabilized atomics and checked_add #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faern
commented
Apr 13, 2019
| use parking_lot_core::{self, SpinWait, DEFAULT_PARK_TOKEN, DEFAULT_UNPARK_TOKEN}; | ||
|
|
||
| #[cfg(has_sized_atomics)] | ||
| type U8 = u8; |
There was a problem hiding this comment.
I split the type definitions from the imports. I find this much more readable.
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Apr 13, 2019
133: Add version detection for stabilized atomics and checked_add r=Amanieu a=faern
Automatically detecting Rust >= 1.34 and make good use of the now stable `AtomicU{8,32}` types as well as `Instant::checked_add`.
This has been broken out from #119 since that PR is a bit large and this commit is not really related to the crate being used in libstd. We don't really know when the libstd stuff will be merged anyway, and this could be immediately useful to anyone using `parking_lot` on the latest stable Rust.
I'm just generally against "let's just put this in the already open PR, it'll be fine". I find it usually creates more problems than it solves.
Co-authored-by: Linus Färnstrand <faern@faern.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatically detecting Rust >= 1.34 and make good use of the now stable
AtomicU{8,32}types as well asInstant::checked_add.This has been broken out from #119 since that PR is a bit large and this commit is not really related to the crate being used in libstd. We don't really know when the libstd stuff will be merged anyway, and this could be immediately useful to anyone using
parking_loton the latest stable Rust.I'm just generally against "let's just put this in the already open PR, it'll be fine". I find it usually creates more problems than it solves.