Fix for two Miri issues with unit tests #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The failing test is unrelated:
|
|
Just remove cloudabi from .travis.yml |
Cloudabi is no longer available from rustup, as it has been moved to tier 3.
|
@bors r+ |
|
Oh wait there's no bors here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #251
With this change, all parking_lot tests pass with Miri with rust-lang/miri#1568 applied, except for the
webkit_queue_tests which are too slow to complete in reasonable time with Miri. (Lowering the number of messages per producer to 100 or 10 makes them pass too.)