Fix linker issues and target support #378
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I don’t think the 3-6 month update cadence of the windows-sys crate was a substantial issue, dropping that dependency (#374) is certainly your choice. However, by doing so you gave up some functionality and target support which will prevent
parking_lot_core
from linking in many cases.The windows and windows-sys crates depend on the windows-targets crate for linker support. The
windows-targets
crate includes only import libs, supports semantic versioning of libs, and optional support for raw-dylib. It provides explicit import libs for the following targets:By contrast, the older
winapi
crate only provided import libs for i686_gnu and x86_64_gnu and lacked support forraw-dylib
, link-level semantic versioning, or ARM64. #374 further yanked all of this and means that dependents must now rely on some other implicit dependency to ensure that this crate’s imports will continue to link.I think restoring
windows-sys
would be simpler in the long run, but as an alternative you can accept this PR which simply adds a dependency on thewindows-targets
crate directly to restore the target support described above.Hope that helps.