Skip to content
This repository has been archived by the owner on Feb 10, 2024. It is now read-only.

White line at the bottom #150

Closed
afalkenhahn opened this issue Jun 18, 2020 · 7 comments
Closed

White line at the bottom #150

afalkenhahn opened this issue Jun 18, 2020 · 7 comments
Assignees
Labels
bug Something isn't working OS:amigaos4

Comments

@afalkenhahn
Copy link

Here's another issue. This program draws everything to a 360x284 texture and then draws this texture scaled to the current screen dimensions. This works fine except that the bottom line is white although it should be black. It's a minor issue, though.

Here is a test program:
temp.zip

@capehill
Copy link
Collaborator

Also on the right side with resolution 1920*1200. Issue seems to depend on the used screen mode. I don't know how driver is using the fixed point scaling factor, but if there is no rounding, it might have some problem.

I tested this by disabling the DEST_Width/Height parameters (making them default) and issue is not caused by clipping. On the other, by increasing ScaleX/Y, white edges disappeared.

I suppose using vertex mode of CompositeTags might be a solution.

@capehill capehill added the bug Something isn't working label Jun 22, 2020
@afalkenhahn
Copy link
Author

afalkenhahn commented Jun 22, 2020 via email

@afalkenhahn
Copy link
Author

I should add that sometimes there's also a white line at the right, not only at the bottom. For example if you run the Turrican 2 example script that comes with RebelSDL in full screen mode. There are white lines at the bottom and the right.

@capehill
Copy link
Collaborator

capehill commented Jul 1, 2020

Yes, it depends on scalex/scaley values (and thus srcrect vs dstrect dimensions) as far as I undertand. It seems like a bug in graphics.library.

@afalkenhahn
Copy link
Author

Ok this makes a fix rather unlikely...

@capehill
Copy link
Collaborator

capehill commented Jul 2, 2020

Turns out the issue has been reported already to OS4 team a long time ago.

I think I change it to use vertex/triangle mode in 2.0.14.

@capehill
Copy link
Collaborator

capehill commented Jan 3, 2021

Closing with 2.0.14 RC1.

@capehill capehill closed this as completed Jan 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working OS:amigaos4
Projects
None yet
Development

No branches or pull requests

2 participants