Update roomSvgExporter.py #84
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello, Thanks for publishing roomSvgExporter. It has been very helpful. However, during development I found that when a model contains Rooms and Spaces they are both exported. This results in doubling up the SVG output when Room and Space boundaries match which was unexpected. I don't understand the reason why but it seems that the Revit API treats Rooms and Spaces the same when it comes to built in parameters like area. So filtering by area isn't enough to differentiate Rooms from Spaces. As a result I added a Category filter to export desired SVG data: Room or Space but not both. Please review the category filter modification in particular. It seems to work OK but I have very little experience writing Dynamo Python scripts. Finally, an output directory input was added to improve control over the output destination. Regards, Jake Staub
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Thanks for publishing roomSvgExporter. It has been very helpful.
However, during development I found that when a model contains Rooms and Spaces they are both exported. This results in doubling up the SVG output when Room and Space boundaries match which was unexpected.
I don't understand the reason why but it seems that the Revit API treats Rooms and Spaces the same when it comes to built in parameters like area. So filtering by area isn't enough to differentiate Rooms from Spaces. As a result I added a Category filter to export desired SVG data: Room or Space but not both. Please review the category filter modification in particular. It seems to work OK but I have very little experience writing Dynamo Python scripts.
Finally, an output directory input was added to improve control over the output destination.
Regards,
Jake Staub